Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying pin policy #299

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Unifying pin policy #299

merged 1 commit into from
Feb 6, 2025

Conversation

amendelzon
Copy link
Collaborator

  • Added pin_policy library implementing both Ledger and SGX pin policies
  • Updated SGX's trusted HAL access module to use the pin policy library for password validation
  • Updated the Ledger UI to use the pin policy library for pin validation
  • Added pin_policy unit tests
  • Updated failing unit tests

Copy link

github-actions bot commented Feb 5, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

- Added pin_policy library implementing both Ledger and SGX pin policies
- Updated SGX's trusted HAL access module to use the pin policy library for password validation
- Updated the Ledger UI to use the pin policy library for pin validation
- Added pin_policy unit tests
- Updated failing unit tests
@amendelzon amendelzon force-pushed the improvement/unify-pin-policy branch from 049083c to 82ffd3b Compare February 5, 2025 20:47
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit ebcf0cc into master Feb 6, 2025
8 checks passed
@amendelzon amendelzon deleted the improvement/unify-pin-policy branch February 6, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants