Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Federation and the complete process until it is confirmed and activated #2925

Open
wants to merge 10 commits into
base: federation_change_federeration_integration
Choose a base branch
from
Open

Create new Federation and the complete process until it is confirmed and activated #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2c9a630
feat(federation): setup new structure for PowpegMigrationTest
apancorb Jan 9, 2025
87741bf
feat(federation): add setup methods, commitPendingFederation, and com…
apancorb Jan 10, 2025
3d97aed
feat(federation): implement assertUTXOsMovedFromNewToOldFederation
apancorb Jan 10, 2025
a1d3c01
feat(federation): add locking cap constants to setup method for int test
apancorb Jan 10, 2025
ca26c8c
feat(federation): move to federation change testing logic to new clas…
apancorb Jan 10, 2025
2f726a7
feat(federation): add change of federation with all activations enabl…
apancorb Jan 10, 2025
1191212
feat(federation): refactor the entire class to accomdate new logic
apancorb Jan 14, 2025
355b873
feat(federation): change test name
apancorb Jan 14, 2025
0f5161b
feat(federation): improve existing tests structure for FederationChan…
apancorb Jan 15, 2025
fa32f4c
feat(federation): remove unused imports from FederationChangeIT
apancorb Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rskj-core/src/main/java/co/rsk/peg/federation/FederationSupportImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ private Integer addFederatorPublicKeyMultikey(boolean dryRun, BtcECKey btcKey, E
* PENDING_FEDERATION_MISMATCHED_HASH if the given hash doesn't match the current pending federation's hash.
* SUCCESSFUL upon success.
*/
private FederationChangeResponseCode commitFederation(boolean dryRun, Keccak256 pendingFederationHash, BridgeEventLogger eventLogger) {
FederationChangeResponseCode commitFederation(boolean dryRun, Keccak256 pendingFederationHash, BridgeEventLogger eventLogger) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we access this method by calling voteFederationChange?

I think we should test this sending the required votes. Make it as realistic as possible. See VoteFederationChangeTest class

// first check that we can commit the pending federation
PendingFederation currentPendingFederation = provider.getPendingFederation();

Expand Down
Loading
Loading