build(slack-notification): Fix rit GH workflow to not send slack notification with empty token #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Vovchyk
force-pushed
the
vovchyk/slack-notif-fix
branch
2 times, most recently
from
46b9f25 to
866c3b5
Compare
…fication with empty token
Vovchyk
force-pushed
the
vovchyk/slack-notif-fix
branch
from
866c3b5 to
534a7b3
Compare
fmacleal
reviewed
Jan 31, 2025
There was a problem hiding this comment.
shouldn't we also have this verification in the failure step?
asoto-iov
previously approved these changes
Jan 31, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: