-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recycle brief
if validation expands into multiple steps
#564
Conversation
@yjunechoe just a note for future work on this PR: #579 changed settings in .Rproj to strip trailing whitespace. Merging from |
Got it - thanks for the heads up! |
@rich-iannone I think this is (finally) ready for review! The PR fixes the problem of Internal detailsThe PR introduces Batch tests are added to TODOI was thinking I should break up the PR as it's getting big. The one missing piece from this PR is supporting multi-length I mentioned the possibility of supporting {glue} syntax in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is great, thanks for all the work you put into it! Will merge this now. |
This PR aims to fix #478 by recycling
brief
when possible.This is a draft PR until I:
resolve_brief()
helper - namely, should it stand on its own (as current) or wrap over the default autobrief behavior, to host allbrief
-related logic? (will move forward with a unifiedresolve_brief()
function)Out of scope but worth considering for afterwards is whether we should support glue sytnax here as well.