Consolidate resource cleanup #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate keys were added for those that were using the `caption` version because the _ (underscore) access key indicator was showing.
Included previously missed RubberduckUI->RefactoringsUI updates.
A suffix was added to differentiate values from those found within the InspectionUI.resx file. Those values are used in the following files: InspectionBase.cs CodeInspectionSettings.cs InspectionTypeConverter.cs Used as `InspectionsUI.ResourceManager.GetString($"CodeInspectionSettings_`.
Expression body member Autoproperty Remove redundant default initialization Remove unnecessary using directive
Use expression body Remove unused local variable Use null propagation Remove redundant explicit array creation in argument Remove unused using directive Convert variables to constants Use auto-property Remove unused resource
|
Close #5408 since it's related. |
retailcoder
requested changes
May 3, 2021
retailcoder
added
the
PR-Status: Conflicting
Values in a format Foo_Bar were migrated to another resource file.
Reasonably confident the strings weren't used or naming was incorrect. Also restored string to permit a valid build.
Some resources that likely aren't used and can be removed were restored in favor of eliminating those that *are* needed.
|
Known conflicts have been resolved. Once this is merged it will permit me to move onto the next domino/PR #5731 and resolve it. |
retailcoder
approved these changes
May 15, 2021
retailcoder
removed
the
PR-Status: Conflicting
|
CC @retailcoder this MR caused #5857 due to an / some incorrect merging in Rubberduck.Core.csproj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All separate branches were merged into this one.
Issue Close #4541
Individual PR: Close #5622, Close #5621, Close #5620, Close #5619, Close #5618.