Language fallbacks #250
Merged
Language fallbacks #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rubenv#210
- baseLanguage is private because it conflicts with catalog's attribute with the same name - plural detection is pretty hardcoded, there's no clear way to know if plural is defined or not
…ew function Removes getStringForm(). See discussion here: rubenv#236 (comment)
Closed
| } | ||
| return null; | ||
| }; | ||
| }); |
There was a problem hiding this comment.
This might be executed a lot. I suggest adding a simple memoization:
angular.module("gettext").factory("gettextFallbackLanguage", function () {
var cache = {};
var pattern = /([^_]+)_[^_]+$/;
return function (langCode) {
if (cache[langCode]) {
return cache[langCode];
}
var matches = pattern.exec(langCode);
if (matches){
cache[langCode] = matches[1];
return matches[1];
}
return null;
};
});There was a problem hiding this comment.
Good call! Added.
Credit goes to rubenv rubenv#250 (diff)
|
Last few things fixed – all ready for merge then? |
|
This looks excellent, I will put this through some testing on our projects. If it doesn't throw up any problems (not expecting any), it'll get merged. |
|
Great! Let me know :) |
|
Works like a charm! |
|
Released as This one still needs updating: https://angular-gettext.rocketeer.be/dev-guide/api/angular-gettext/ (website is in git here: https://github.com/rubenv/angular-gettext-website). I'll do that myself in a minute. Thanks, a lot! |
|
Great work guys. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes languages fall back onto their base language:
en_GB→en,de_CH→de, etc.› Original issue: #210
› Original PR: #236
Notable changes:
getStringForm()gettextFallbackLanguage()methodLet me know if you have any better suggestions for better naming, or if there is anything else that could be improved upon.