Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake: Support task arguments and sh with env hash #765

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

sue445
Copy link
Contributor

@sue445 sue445 commented Jan 9, 2025

This patch 2 changes to rake

  1. Support rake task arguments within task block
  2. Support env hash to FileUtils#sh in rake

@sue445 sue445 force-pushed the add_rake_task_args branch from e4708d8 to 6af03ea Compare January 9, 2025 15:21
Copy link

github-actions bot commented Jan 9, 2025

@sue445 Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

rake

You changed RBS files for an existing gem.
This gem does not have reviewers. So you can merge this PR immediately if the CI passes.
We recommend you add yourself to the reviewers for this gem.

@sue445
Copy link
Contributor Author

sue445 commented Jan 9, 2025

/merge

@github-actions github-actions bot merged commit 7651e7b into ruby:main Jan 9, 2025
5 checks passed
@sue445 sue445 deleted the add_rake_task_args branch January 9, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant