Skip to content

Commit

Permalink
Revert "Add error handling for missing railroad_diagrams gem" and mov…
Browse files Browse the repository at this point in the history
…e to add_runtime_dependency

This reverts commit 91c5879.
  • Loading branch information
ydah committed Feb 1, 2025
1 parent 3fff7f2 commit 4f4f479
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ gem "rspec"
gem "simplecov", require: false
gem "stackprof", platforms: [:ruby] # stackprof doesn't support Windows
gem "memory_profiler"
gem "railroad_diagrams", "0.2.1"

# Recent steep requires Ruby >= 3.0.0.
# Then skip install on some CI jobs.
Expand Down
8 changes: 1 addition & 7 deletions lib/lrama/diagram.rb
Original file line number Diff line number Diff line change
@@ -1,19 +1,14 @@
# frozen_string_literal: true

require "erb"
begin
require "railroad_diagrams"
rescue LoadError
warn "railroad_diagrams is not installed. Please run `bundle install`."
end
require "railroad_diagrams"

module Lrama
class Diagram
def initialize(out:, grammar:, template_name: 'diagram/diagram.html')
@grammar = grammar
@out = out
@template_name = template_name
return unless defined?(RailroadDiagrams) # Skip rendering if railroad_diagrams is not installed
RailroadDiagrams::TextDiagram.set_formatting(RailroadDiagrams::TextDiagram::PARTS_UNICODE)
end

Expand All @@ -28,7 +23,6 @@ def self.erb(input)
end

def render
return unless defined?(RailroadDiagrams) # Skip rendering if railroad_diagrams is not installed
@out << render_template(template_file)
end

Expand Down
1 change: 1 addition & 0 deletions lrama.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
spec.bindir = "exe"
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]
spec.add_runtime_dependency "railroad_diagrams", "0.2.1"
end

0 comments on commit 4f4f479

Please sign in to comment.