Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance diagram display with hover effects and improved styling #529

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

ydah
Copy link
Member

@ydah ydah commented Feb 6, 2025

This PR adds hover effects to the diagram nodes and header, and improves the styling of the diagram.
This improves the HTML rendering in SyntaxDiagrams.

As shown in the image below, hovering over elements changes the background color of headers and non-terminals/terminals.
Additionally, clicking on a non-terminal scrolls to its definition.

2025-02-07.1.27.33.mov

These enhancements further improve the usability of SyntaxDiagrams.

This PR adds hover effects to the diagram nodes and header, and improves the styling of the diagram.
This improves the HTML rendering in SyntaxDiagrams.

As shown in the image below, hovering over elements changes the background color of headers and non-terminals/terminals.
Additionally, clicking on a non-terminal scrolls to its definition.

https://github.com/user-attachments/assets/f48b373d-1bd2-4c43-b092-de9214c3089e

These enhancements further improve the usability of SyntaxDiagrams.
@ydah ydah requested a review from yui-knk February 7, 2025 12:49
@ydah ydah merged commit 891aa38 into ruby:master Feb 8, 2025
22 checks passed
@ydah ydah deleted the improve-diagram branch February 8, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants