Merge pull request #1688 from ksss/UnresolvedOverloadingError-details

Add more details error message for UnresolvedOverloadingError
ruby · Dec 19, 2023 · 3a965cb · 3a965cb
2 parents 2fdb2e9 + 561f446
commit 3a965cb
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 15 deletions.
diff --git a/lib/rbs/test/type_check.rb b/lib/rbs/test/type_check.rb
@@ -35,6 +35,17 @@ def overloaded_call(method, method_name, call, errors:)
         if es.size == 1
           errors.push(*es[0])
         else
+          RBS.logger.warn do
+            message = +"[#{self_class}#{method_name}] UnresolvedOverloadingError "
+            message << method.method_types.zip(es).map do |method_type, es|
+              msg = +"method_type=`#{method_type}`"
+              details = es.map do |e|
+                "\"#{Errors.to_string(e).sub("[#{e.klass.name}#{e.method_name}] ", "") }\""
+              end.join(', ')
+              msg << " details=[#{details}]"
+            end.join(', ')
+            message
+          end
           errors << Errors::UnresolvedOverloadingError.new(
             klass: self_class,
             method_name: method_name,

diff --git a/test/rbs/test/type_check_test.rb b/test/rbs/test/type_check_test.rb
@@ -517,22 +517,28 @@ def bar: () -> String
             assert_instance_of RBS::Test::Errors::ReturnTypeError, errors[0]
           end
 
-          typecheck.overloaded_call(
-            foo.methods[:foo],
-            "#foo",
-            Test::CallTrace.new(
-              method_name: :foo,
-              method_call: Test::ArgumentsReturn.return(
-                arguments: [3],
-                value: 30
+          begin
+            RBS.logger_output = logger = StringIO.new
+            typecheck.overloaded_call(
+              foo.methods[:foo],
+              "#foo",
+              Test::CallTrace.new(
+                method_name: :foo,
+                method_call: Test::ArgumentsReturn.return(
+                  arguments: [3],
+                  value: 30
+                ),
+                block_calls: [],
+                block_given: false
               ),
-              block_calls: [],
-              block_given: false
-            ),
-            errors: []
-          ).tap do |errors|
-            assert_equal 1, errors.size
-            assert_instance_of RBS::Test::Errors::UnresolvedOverloadingError, errors[0]
+              errors: []
+            ).tap do |errors|
+              assert_equal 1, errors.size
+              assert_instance_of RBS::Test::Errors::UnresolvedOverloadingError, errors[0]
+              assert_match '[Object#foo] UnresolvedOverloadingError method_type=`() -> ::String` details=["ArgumentError: expected method type () -> ::String", "ReturnTypeError: expected `::String` but returns `30`"], method_type=`(::Integer) -> ::String` details=["ReturnTypeError: expected `::String` but returns `30`"]', logger.string
+            end
+          ensure
+            RBS.logger_output = nil
           end
         end
       end