New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MatchData #1568

Closed

sampersand wants to merge 2 commits into ruby:master from sampersand:swesterman/23-09-25/match_data

Contributor

sampersand commented Oct 15, 2023 •

edited

Loading

This PR updates MatchData and its associated tests, as well as adds String::_Match.

More specifically, this makes the following semantic updates:

MatchData::backref: Added, equal to String | Symbol | int
MatchData#[]: Updated to use backref, implicit ints, and range[int?]
MatchData#{begin,end,match,match_length,offset}: Updated to use backref
MatchData#deconstruct_keys: Named argument keys
MatchData#eql?: Now an alias for ==
MatchData#length: Now an alias for size
MatchData#named_captures: Added symbolize_names and annotation for >= 3.3.0
MatchData#values_at: Now uses backref and range[int?]
MatchData#initialize_copy: Takes an instance and returns void.

TODO: Add tests for [], values_at, and initialize_copy.


          Update MatchData

d487edf

sampersand force-pushed the swesterman/23-09-25/match_data branch from 890e95f to d487edf Compare

October 15, 2023 23:05


          freaking range

50277ef

Contributor Author

sampersand commented Feb 8, 2024

Looks like this is already in master

sampersand closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet