Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bundler.ui instead of ColoredIO #1577

Closed
wants to merge 1 commit into from
Closed

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Oct 19, 2023

The ColoredIO introduced in #1558 is based on Bundler's implementation.
The goal was to aim for a minimal implementation independent of bundler, but I realized that rbs does require bundler.
I wonder if it would be more efficient to use Bundler.ui directly to avoid duplicate implementations and also utilize its rich features.

What do you think?


I think we should stop passing stdout as an argument.
It would be more consistent and simplify the code to always use $stdout, allowing it to be replaced from the outside, which also makes it easier to integrate with other tools like 'Bundler.ui'.
On the other hand, using it as an argument complicates the API and integration with other tools, making the code more complex.

@pocke
Copy link
Member

pocke commented Oct 22, 2023

I am against this proposal because RBS is not Bundler. Bundler.ui looks like an internal API to implement Bundler's UI, so other programs should not use this API.

@ksss
Copy link
Collaborator Author

ksss commented Oct 22, 2023

Indeed, you are right.
It seems I was under the impression that Bundler.ui was a public API.

@ksss ksss closed this Oct 22, 2023
@ksss ksss deleted the bundler-ui branch October 22, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants