Use Bundler.ui instead of ColoredIO #1577
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ColoredIO
introduced in #1558 is based onBundler
's implementation.The goal was to aim for a minimal implementation independent of bundler, but I realized that rbs does require bundler.
I wonder if it would be more efficient to use
Bundler.ui
directly to avoid duplicate implementations and also utilize its rich features.What do you think?
I think we should stop passing
stdout
as an argument.It would be more consistent and simplify the code to always use
$stdout
, allowing it to be replaced from the outside, which also makes it easier to integrate with other tools like 'Bundler.ui'.On the other hand, using it as an argument complicates the API and integration with other tools, making the code more complex.