Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Bundler lazily #1612

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Load Bundler lazily #1612

merged 1 commit into from
Nov 15, 2023

Conversation

pocke
Copy link
Member

@pocke pocke commented Nov 10, 2023 •
edited
Loading

Loading Bundler at the top-level causes a problem on testing for ruby/ruby. So this PR makes it lazy.

It will also improve the performance of launching rbs command (except rbs collection).

cc/ @hsbt

soutaro
soutaro approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.3.x milestone Nov 10, 2023
hsbt
hsbt approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@hsbt hsbt mentioned this pull request Nov 10, 2023
Merged
4 tasks
@pocke pocke added this pull request to the merge queue Nov 15, 2023
Merged via the queue into ruby:master with commit 47a57ff Nov 15, 2023
23 checks passed
@pocke pocke deleted the Load_Bundler_lazily branch November 15, 2023 15:27
@soutaro soutaro added the Released PRs already included in the released version label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

@hsbt hsbt hsbt approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@pocke @hsbt @soutaro