Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test #1616

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix flaky test #1616

merged 1 commit into from
Nov 22, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Nov 11, 2023

The order in which tests are run could lead to test failures.
This is happening because RBS::CLI::ColoredIO is used within RBS::Collection but has not been loaded.

ref: https://github.com/ruby/rbs/actions/runs/6833184489?pr=1615

@soutaro soutaro added this to the RBS 3.4 milestone Nov 22, 2023
@soutaro soutaro enabled auto-merge November 22, 2023 01:54
@soutaro soutaro added this pull request to the merge queue Nov 22, 2023
Merged via the queue into ruby:master with commit a196be1 Nov 22, 2023
23 checks passed
@ksss ksss deleted the fix_colored_io branch November 22, 2023 02:41
soutaro added a commit that referenced this pull request Dec 20, 2023
@soutaro
Revert "Merge pull request #1616 from ksss/fix_colored_io"
b7f9439 
This reverts commit a196be1, reversing
changes made to 518b2e6.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro