Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --detail option to rbs diff #1623

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Add --detail option to rbs diff #1623

merged 2 commits into from
Nov 22, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Nov 17, 2023

The rbs diff command has been released, but the initially planned feature to display definition class information and accessibility information was dropped. In this PR, I've made it so that adding an option allows for displaying and comparing more detailed information.

proposal: #1448

@soutaro soutaro added this to the RBS 3.4 milestone Nov 20, 2023
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this pull request to the merge queue Nov 22, 2023
Merged via the queue into ruby:master with commit 77328dd Nov 22, 2023
24 checks passed
soutaro added a commit that referenced this pull request Dec 20, 2023
This reverts commit 77328dd, reversing
changes made to c8327f1.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants