Change return type of lifecycle hooks in minitest
to be void
#1694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, many thanks for all the work on RBS.
I am proposing a change to the Lifecycle hooks of
Minitest::Test
so that they arevoid
instead ofnil
.Otherwise any time we use the
setup
hook for example, we need to explicitly returnnil
but normally we don't care what we return from these methods. The return value is not used inminitest
I believe (https://github.com/minitest/minitest/blob/master/lib/minitest/test.rb#L91)I wasn't really sure about how to use the
assert_send_type
test helper but I tried to write a test anyway.Let me know what you think.