Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO#each_line and Kernel#readlines accept chomp: true #2151

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

ParadoxV5
Copy link
Contributor

  • Help wanted: testing
    • Broken Windows Theory: We don’t need to test those because IO and Kernel don’t have complete test coverage.

@soutaro soutaro added this to the RBS 3.8 milestone Dec 16, 2024
@soutaro
Copy link
Member

soutaro commented Dec 16, 2024

exit won't have any output... 14ea43f

I was confused. The problem would be readlines requiring STDIN input. (?)

@soutaro
Copy link
Member

soutaro commented Dec 16, 2024

Inserting something to ARGV helps returning the readlines calls. https://rubyapi.org/3.3/o/argf

@soutaro
Copy link
Member

soutaro commented Dec 23, 2024

I tried to implement a test for Kernel#readlines through ARGV, but it blocks on the second call during the test. 😢

@soutaro soutaro enabled auto-merge December 23, 2024 04:21
@soutaro soutaro added this pull request to the merge queue Dec 23, 2024
Merged via the queue into ruby:master with commit 5e22528 Dec 23, 2024
19 checks passed
@soutaro soutaro added the Released PRs already included in the released version label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants