[rbs/unit_test] Treat nil as a return value #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`%a{implicitly-returns-nil}` cannot be checked to return `nil`
```
'\u{e4 f6 fc}'.encode('ISO-8859-1').to_sym.casecmp?(:'\u{c4 d6 dc}')
=> false
```
``` map.getkey(123) => nil ```
Since the return values of some methods have changed, we use gem to fix the behavior.
ksss
changed the title
|
I made changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Ruby side, when
nilis returned,rbs/unit_testinterprets it as a break, which revealed that the return value was not being checked.I have fixed this issue and also fixed the tests that depended on this issue.