Fix function parameters to support C23 #66
Conversation
|
As I wrote in #65 , there are many functions with K&R style in tcltk.c, however I don't think we no longer have to support K&R style. |
|
I would like to have ruby-tk build with C23, but we need to ensure compatibility with older compilers as well. I've enabled the CI build for this PR, but the fail-fast makes it difficult to debug. I'll push a change to disable fail-fast. |
|
If you rebase this on master, it should will turn off the fail-fast code, and you can see if the issue affects just ruby-head, or all ruby versions. |
C23 regards function prototype with no parameter list as that with taking no parameter (i.e. `func(void)`). Esplicitly write parameter list to support C23. Closes ruby#65 .
|
The above CI failure is due to identifier omission in function definition which is C23 feature not in C17, I modified a patch a bit. |
|
CI looks good now. Are you aware of any issues with this patch building on compilers that only support C99 (this is the C version Ruby targets, and ruby-tk should also build with it)? |
|
C99 should be okay with my patch (this PR). BTW if C99 is the lowest target ruby-tk (and ruby) should support, I think (after this PR is merged) we can clean up K&R style function declaration. |
OK. I'll merge this shortly.
Yes, that would be a good improvement. |
C23 regards function prototype with no parameter list as that with taking no parameter (i.e.
func(void)).Esplicitly write parameter list to support C23.
Closes #65 .