Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old K&R style function declaration #68

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

mtasaka
Copy link
Contributor

@mtasaka mtasaka commented Jan 17, 2025

Remove old K&R style function declaration.

Also after this change is done, some mistakes are found, fixing this.

Since ruby-tk require C99 or higher, clean up
old K&R style function declaration (which is before
C89).
Fix funciton prototype for
* watchdog_evloop_launcher (argument for rb_thread_create)
* _thread_call_proc (argument for rb_thread_create)
* rb_eval_string (argument for tcl_protect)
* ip_ruby_cmd_receiver_const_get (argument for rb_protect)
* ip_ruby_cmd_core (argument for tcl_protect)
* create_encoding_table_core (argument for rb_proc_new)

Also fix argument for rb_define_module_function when called with
* lib_getversion (no argument)
* lib_get_reltype_name (no argument)
Fix funciton prototype for
* tkstr_invalid_numstr (argument for rb_rescue2)
* tkstr_rescue_float (argument for rb_rescue2)
* tkstr_to_str (argument for rb_rescue2)
* subst_mark (for struct rb_data_type_t)
* subst_free (for struct rb_data_type_t)
* subst_memsize (for struct rb_data_type_t)
@jeremyevans
Copy link
Contributor

Thank you very much for working on this!

@jeremyevans jeremyevans merged commit 3ae4c39 into ruby:master Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants