Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to attach multiple sockets #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ikhsan
Copy link
Contributor

@ikhsan ikhsan commented Feb 3, 2024

For #372

  • Introduce a new adapter MultiSessionDebugAdapter where it emits events with all socket paths
  • Add a listener that subscribes to custom events that MultiSessionDebugAdapter emits, which attach it as a child process
  • This is enabled via supportAttachMultiSockets config

Screenshot

When running a rails server with 4 processes

Before After
Screenshot 2024-02-03 at 22 29 51 Screenshot 2024-02-03 at 22 31 41
when set tofalse, it defaults to the picker selector when set to true, it attaches all as child processes

@ikhsan ikhsan changed the title Allow to attach to multiple sockets Support to attach multiple sockets Feb 3, 2024
@ono-max
Copy link
Member

ono-max commented Feb 24, 2024

@ikhsan

Thank you for your work! Sorry, I'm not familiar with multiple process debugging. Can you please give me the sample project to experiment the behavior?

@ikhsan
Copy link
Contributor Author

ikhsan commented Feb 25, 2024

@ono-max sure thing. I've created the demo app here: https://github.com/ikhsan/attach-multi-socket

Sorry, I'm not familiar with multiple process debugging.

The setup for multi process is here: ikhsan/attach-multi-socket@7e65b1d. This is copied from our original app.

Steps

Let me know if the demo does or doesn't work 🙏

@ikhsan
Copy link
Contributor Author

ikhsan commented Apr 18, 2024

Thank you for your work! Sorry, I'm not familiar with multiple process debugging. Can you please give me the sample project to experiment the behavior?

Hey @ono-max 👋 just want to touch point with you on this. Did you have the chance to try debugging with the demo app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants