Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HAML 6 #1426

Merged
merged 2 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ gem "middleman-syntax"

## Template engines
gem "builder"
gem "haml", "~> 5.2.2"
gem "haml", "~> 6.3"
gem "kramdown"

# Rake tasks
Expand Down
7 changes: 4 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,9 @@ GEM
ffi (1.17.1)
ffi (1.17.1-arm64-darwin)
ffi (1.17.1-x86_64-linux-gnu)
haml (5.2.2)
temple (>= 0.8.0)
haml (6.3.0)
temple (>= 0.8.2)
thor
tilt
haml_lint (0.59.0)
haml (>= 5.0)
Expand Down Expand Up @@ -247,7 +248,7 @@ PLATFORMS
DEPENDENCIES
builder
faraday-retry (~> 2.2)
haml (~> 5.2.2)
haml (~> 6.3)
haml_lint (~> 0.59)
irb
kramdown
Expand Down
2 changes: 1 addition & 1 deletion source/contributors.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ title: Contributors
- data.contributors.each do |c|
%span.contributor
= link_to c[:name], c[:href], title: "#{pluralize(c[:commits], "commit")}"
= " • " unless c == data.contributors.last
!= " • " unless c == data.contributors.last
%br
%p
…and everyone who has given time, effort, thought, or help, instead of git commits <3
2 changes: 0 additions & 2 deletions source/layouts/base.haml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,5 @@

~ yield

= yield_content :tail

.footer
= partial 'layouts/footer'
18 changes: 7 additions & 11 deletions source/layouts/two_column_layout.haml
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,8 @@
- content_for(:canonical, commands_toplevel_path(current_page.destination_path))

~ wrap_layout :base do
- content_for :tail do
.bg-light-blue
.container
.contents
.edit-on-github.text-center
= link_to_editable_version
= partial 'partials/docs_header'

.bg-light-blue.header
= image_tag '/images/docs_header_transparent_bg.png',
srcset: '/images/docs_header_transparent_bg.png 1x, /images/[email protected] 2x, /images/[email protected] 3x',
class: 'img-fluid header-padding',
style: 'max-width: 400px;'
.container
.row.flex-column.flex-md-row-reverse
.col-12.col-md-9.contents#page-content-wrapper{ class: is_command ? "commands" : "guide" }
Expand All @@ -29,3 +19,9 @@
= partial 'partials/guides_sidebar'

= javascript_include_tag 'two_column_layout.min'

.bg-light-blue
.container
.contents
.edit-on-github.text-center
= link_to_editable_version
2 changes: 1 addition & 1 deletion source/localizable/index.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
.container.py-5
.mx-xl-5.px-xl-5.my-4.large-font
%p= t('home.bundler_info1')
%p= t('home.bundler_info2')
%p!= t('home.bundler_info2')

.d-grid.d-md-flex.gap-2.mx-auto.my-md-4.justify-content-md-center
= link_to t('home.what_can_bundler_do'), "/guides/getting_started.html#getting-started", class: 'btn btn-primary btn-lg'
Expand Down
5 changes: 5 additions & 0 deletions source/partials/_docs_header.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.bg-light-blue.header
= image_tag '/images/docs_header_transparent_bg.png',
srcset: '/images/docs_header_transparent_bg.png 1x, /images/[email protected] 2x, /images/[email protected] 3x',
class: 'img-fluid header-padding',
style: 'max-width: 400px;'