Fix importing doc pages from rubygems/rubygems #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
restore-doc-pages
branch
from
5c0b853 to
21c402e
Compare
This got broken after Bundler docs moved folders. Co-authored-by: Olle Jonsson <[email protected]>
We changed these because the links got broken after the Bundler documentation folder was moved in rubygems/rubygems. Now that's fixed so those can be restored.
deivid-rodriguez
force-pushed
the
restore-doc-pages
branch
from
21c402e to
84e6137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that after bundler documentation folder was renamed in rubygems/rubygems#8159, importing documentation pages from rubygems/rubygems broken.
This has caused a bunch of broken links.
For example, the first result of a Google search of "bundler bug triage" is now a broken link.
What was your diagnosis of the problem?
My diagnosis was we should fix importing those pages to restore all previous links indexed by Google.
What is your fix for the problem, implemented in this PR?
My fix is to adapt to the upstream folder rename.
I also restore linking to the "on-site" contributing guide, since the page is now there again.
Why did you choose this fix out of the possible options?
I chose this fix because it makes the most sense to improve Bundler documentation discoverability and keep it SEO friendly.