Remove Adoptions

[martinemde]

See the Remove Adoptions RFC for more details.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.00%. Comparing base (0b6886d) to head (4180bf7).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5356      +/-   ##
==========================================
- Coverage   97.14%   97.00%   -0.14%     
==========================================
  Files         458      451       -7     
  Lines        9584     9396     -188     
==========================================
- Hits         9310     9115     -195     
- Misses        274      281       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[simi]

@martinemde I have updated few bits to make tests and linters passing again. OK to consider ready for review?

[martinemde]

Thanks for your help @simi. I think it’s ready.

[simi]

@martinemde seems reported missing coverage is related to removed functionality. Tests are passing with following diff. Would it make sense to remove also?

diff --git a/app/helpers/owners_helper.rb b/app/helpers/owners_helper.rb
index a9fcfc214..7cb74e73a 100644
--- a/app/helpers/owners_helper.rb
+++ b/app/helpers/owners_helper.rb
@@ -18,10 +18,4 @@ module OwnersHelper
       image_tag("/images/check.svg")
     end
   end
-
-  def sanitize_note(text)
-    options = RDoc::Options.new
-    options.pipe = true
-    simple_format RDoc::Markup.new.convert(text, RDoc::Markup::ToHtml.new(options))
-  end
 end
diff --git a/app/policies/application_policy.rb b/app/policies/application_policy.rb
index d7bf716f2..e7e80d611 100644
--- a/app/policies/application_policy.rb
+++ b/app/policies/application_policy.rb
@@ -31,11 +31,6 @@ class ApplicationPolicy
     false
   end
 
-  def allow
-    @error = nil
-    true
-  end
-
   def current_user?(record_user)
     user && user == record_user
   end
@@ -59,9 +54,4 @@ class ApplicationPolicy
 
   def policy!(user, record) = Pundit.policy!(user, record)
   def user_policy!(record) = policy!(user, record)
-
-  def user_authorized?(record, action)
-    policy = user_policy!(record)
-    policy.send(action) || deny(policy.error)
-  end

[martinemde]

@simi might as well. We can add it back if needed later.

[segiddins]

why is this not being removed?

[martinemde]

It’s used elsewhere. Probably it should be renamed.