Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set disabled button cursor to 'not-allowed' #5372

Conversation

w-masahiro-ct
Copy link
Contributor

SSIA

@w-masahiro-ct w-masahiro-ct force-pushed the set-disabled-button-cursor-to-not-allowed branch from ea9b0b1 to e0d2559 Compare December 31, 2024 18:23
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (9587ad5) to head (e0d2559).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5372      +/-   ##
==========================================
- Coverage   97.14%   94.37%   -2.77%     
==========================================
  Files         458      458              
  Lines        9584     9643      +59     
==========================================
- Hits         9310     9101     -209     
- Misses        274      542     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins
Copy link
Member

Could you please add some more context for this change? I'm not sure what SSIA means

@w-masahiro-ct
Copy link
Contributor Author

@segiddins SSIA means subject says it all.
I changed cursor from pointer to not-allowed because disabled button shuldn't be clicked.
That's all.

@w-masahiro-ct
Copy link
Contributor Author

w-masahiro-ct commented Jan 8, 2025

Before

before

After

after

Edit is disabled button.

@segiddins segiddins merged commit 8d21b3b into rubygems:master Jan 8, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants