Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time zone gems to geocoding___maps.yml #739

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

HarlemSquirrel
Copy link
Contributor

@HarlemSquirrel HarlemSquirrel commented Feb 23, 2023

Add some time zone gems

Thanks for contributing to the Ruby Toolbox catalog! <3

Before submitting your pull request:

  • If you're referencing a gem by its GitHub repository (e.g. rails/rails), please verify
    that it is not packaged as a Ruby gem. (If it is packaged as a gem, please reference it
    by its gem name instead, e.g. rails.)
  • Please make sure the projects are listed in case-insensitive alphabetical order
  • Make sure the CI build passes, we validate your proposed changes in the test suite :)

Add some time zone gems
@colszowka
Copy link
Member

@HarlemSquirrel Thans for contributing! I think given that we already have the Time & Space category group and these being somewhat distinct from geocoding & maps related stuff I think it would be warranted to instead move them into their own Timezones category in the Time & Space group, what do you think?

@HarlemSquirrel
Copy link
Contributor Author

@colszowka Could you take another look at this?

@colszowka colszowka merged commit e2da07e into rubytoolbox:main Jan 19, 2024
4 checks passed
@colszowka
Copy link
Member

@HarlemSquirrel Sorry for the lag, merging! Thanks for your contribution 👍

@HarlemSquirrel HarlemSquirrel deleted the add-time-zone-gems branch January 19, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants