-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Health Check category group #764
Add Health Check category group #764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing @andrepiske, please check out the 2 comments I have left, other than that good to go 👍
@@ -0,0 +1,12 @@ | |||
name: Health Check | |||
description: | |||
projects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indentation is wrong and needs to be top level, this currently makes the build fail
@@ -0,0 +1,12 @@ | |||
name: Health Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should go with plural "Health Checks" here please, i.e. we have "Web App Frameworks"; "JSON Parsers" and so on, and I suppose the gems themselves might also be capable of doing multiple checks depending on the use case so plural makes sense there as well
When in doubt, it would also be a nice to add a brief category description while we're at it, something like
|
- Fix indentation - Add description - Make the name in plural
@colszowka hey I've made the changes you requested! Just took me a few months 🙄 |
Thanks @andrepiske, only a few months later this is now reviewed and I'm merging this, thanks for your contribution! |
Adds the Health Check category group with a non-extensive list of projects. Addresses rubytoolbox/rubytoolbox#1090
The goal is to list gems that provide some form of web/API endpoint(s) that perform health check (or liveness/readiness checks) by a third party. This is not about gems that call those endpoints.
Before submitting your pull request:
rails/rails
), please verifythat it is not packaged as a Ruby gem. (If it is packaged as a gem, please reference it
by its gem name instead, e.g.
rails
.)