Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filterameter gem to Rails Search category #872

Merged

Conversation

toddkummer
Copy link
Contributor

This gem enables filter parameters to be declared in query classes or controlllers.

https://rubygems.org/gems/filterameter

Thanks for contributing to the Ruby Toolbox catalog! <3

Before submitting your pull request:

  • N/A If you're referencing a gem by its GitHub repository (e.g. rails/rails), please verify
    that it is not packaged as a Ruby gem. (If it is packaged as a gem, please reference it
    by its gem name instead, e.g. rails.)
  • Please make sure the projects are listed in case-insensitive alphabetical order
  • Make sure the CI build passes, we validate your proposed changes in the test suite :)

@toddkummer
Copy link
Contributor Author

All three CI steps pass locally. Are there additional steps I should complete for this PR?

This gem enables filter parameters to be declared in query classes or controlllers.

https://rubygems.org/gems/filterameter
@colszowka colszowka force-pushed the add-filterameter-gem-to-rails-search branch from baaa70b to 7748961 Compare June 28, 2024 11:19
@colszowka colszowka merged commit 5c7c5e3 into rubytoolbox:main Jun 28, 2024
4 checks passed
@colszowka
Copy link
Member

Thanks for contributing @toddkummer - Not sure what went wrong there, somehow the build got stuck it seemed. It all worked fine again after a rebase.

I merged this now, although I think some cleanup is in order between the search / scopes categories and a category which I think is actually missing so far, for query filters, like this one or rubanok: rubytoolbox/rubytoolbox#1356

If you are interested in taking a look, please feel free to submit a PR against this too 👍

@toddkummer
Copy link
Contributor Author

@colszowka I created the following PR to split up the category. There are definitely (at least) two types of gems in it.

#901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants