Update rubocop-rspec 2.31.0 → 3.0.2 (major)

[depfu]

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.31.0 → 3.0.2) · Repo · Changelog

Release Notes

3.0.2

• Fix wrong autocorrect for RSpec/ScatteredSetup when hook contains heredoc. (@earlopain)
• Fix false negative for RSpec/PredicateMatcher when expectation contains custom failure message. (@earlopain)
• Facilitate the 3.0 upgrade flow with proper extracted cop messages. (@jeppester)

3.0.1

• Bump RuboCop requirement to +1.61. (@ydah)

3.0.0

• Remove extracted cops in Capybara, FactoryBot and Rails departments. (@ydah)
• Remove RuboCop::RSpec::Language::NodePattern. (@ydah)
• Remove RSpec/FilePath cop. (@ydah)
• Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@ydah)
• Add new RSpec/MissingExpectationTargetMethod cop. (@krororo)
• Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@earlopain)

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rexml (indirect, 3.3.0 → 3.3.1) · Repo · Changelog

Release Notes

3.3.1

Improvements

• Added support for detecting malformed top-level comments.

  • GH-145
  • Patch by Hiroya Fujinami.

• Improved REXML::Element#attribute performance.

  • GH-146
  • Patch by Hiroya Fujinami.

• Added support for detecting malformed <!--> comments.

  • GH-147
  • Patch by Hiroya Fujinami.

• Added support for detecting unclosed DOCTYPE.

  • GH-152
  • Patch by Hiroya Fujinami.

• Added changlog_uri metadata to gemspec.

  • GH-156
  • Patch by fynsta.

• Improved parse performance.

  • GH-157
  • GH-158
  • Patch by NAITOH Jun.

Fixes

• Fixed a bug that large XML can't be parsed.

  • GH-154
  • Patch by NAITOH Jun.

• Fixed a bug that private constants are visible.

  • GH-155
  • Patch by NAITOH Jun.

Thanks

• Hiroya Fujinami

• NAITOH Jun

• fynsta

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 13 commits:

• Add 3.3.1 entry
• Optimize BaseParser#unnormalize method (#158)
• Reuse of Set.new at prefixes variables (#157)
• Add changelog_uri to gemspec (#156)
• Don't include private_constant-ed module (#155)
• Fix a bug that a large XML can't be parsed (#154)
• Reject unclosed DOCTYPE on parsing (#153)
• Add a "Malformed comment" check for invalid comments such as `<!-->` (#147)
• Fix small typos (#148)
• Improve `Element#attribute` implementation as 6500x faster (#146)
• Add a "malformed comment" check for top-level comments (#145)
• Remove an unused class var `@@namespaces` (#144)
• Bump version

🗑️ rubocop-capybara (removed)

🗑️ rubocop-factory_bot (removed)

🗑️ rubocop-rspec_rails (removed)

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu cancel merge

Cancels automatic merging of this PR

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)