Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibYAML, LuaJIT, Jansson packages #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

btbytes
Copy link

@btbytes btbytes commented May 4, 2016

No description provided.

@btbytes btbytes changed the title Add LuaJIT package Add LibYAML, LuaJIT packages May 4, 2016
@btbytes btbytes changed the title Add LibYAML, LuaJIT packages Add LibYAML, LuaJIT, Jansson packages May 4, 2016
@anttikantee
Copy link
Member

Thanks.

Did you test that the various libraries also work?

What is the advantage of the pkg'ized zlib as opposed to the one provided by the Rumprun base build?

Please rebase your changes clean them up, e.g. s/JANSSON/NET/ doesn't belong into the zlib commit.

I invited you to the github rumprun-packages team.

@btbytes
Copy link
Author

btbytes commented May 8, 2016

@anttikantee Thanks.

  • I'll rebase my changes
  • I did not know zlib shipped with rumprun. Also, how do I refer to packages provided by the base build? I know i can refer to the rumprun-packages with RUMPRUN_PKGS_DIR. nvm, I found out about RUMPRUN_SYSROOT.

@anttikantee
Copy link
Member

The base libs and headers should automatically be picked up by the compiler, so simply -lz should work.

@anttikantee
Copy link
Member

@btbytes are you planning to merge this, or are there still issues?

(one might also argue that you rebased too much, one commit per new package would be the logical granularity, but let's not view that as a showstopper)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants