-
Notifications
You must be signed in to change notification settings - Fork 736
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@jerryjliu , I just created a patch to use Waii as a tool from Llama. I think be able to ask questions about complex query generation, diff queries, describe dataset, do perf analysis, etc. Which I think it is pretty cool. Here's notebook examples: https://github.com/wangdatan/llama-hub/blob/main/llama_hub/tools/notebooks/waii.ipynb Looking forward to hear your feedback about it. If you or anybody want to test this out yourself, I will be happy to share test account / API-key for you to test. |
@wangdatan can you fix the tests, please? need to be lazy imports to the tests pass |
@EmanuelCampos , thank you for the review. I just updated lazy imports. |
@wangdatan sorry for the delay on this, will review soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! some comments:
- it might be good to turn verbose=True in the notebook, will be good for users to see what tools are specifically being called for these user queries
- you have a lot of tool functions in the tool spec, which 1) thanks for doing all this, 2) the main risk is more tools tends to confuse agents. is there a subset of this that you think agents must know to operate effectively? e.g. i'm trying to get intuition on when the agent would call fn's like "performance_analyze", "transcode", etc. But you've thought about this more than ihave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops didn't mean to approve yet, lmk your thoughts
@jerryjliu thank you for reviewing. Both are good suggestions. For 1. I will update it so the user can see what happens behind-the-scene. For 2. My intention was, that the Waii LlamaIndex tool is something users can use to finish most of their SQL tasks, no matter if it is query generation, query transcode, or performance analysis. But I think some of the use cases are somehow orthogonal to each other. Maybe we can split it into multiple tools (I'm open to your suggestions): a.
I think these use cases are relatively separate from each other. Do you think if LLM (I tried to use GPT-4 as agent, it seems handles these use cases pretty well). b. But since waii-perf is just one single function call, I'm not sure if it is worthwhile to separate it out. |
@wangdatan thanks for the detailed response. I think it's ok to keep as one tool spec - actually this may be one us to let users "pick" the functions they want to use with |
Let me know when it's ready for review and I can approve! |
Thank you @jerryjliu . I think it is ready for review. Let me know if I missed anything since this is my first LlamaHub PR 😃 |
did you update with verbose=True? |
Oops, I forgot, I will do it tonight |
@jerryjliu I just added verbose=True to the notebook example. |
Thank you for reviewing and merging it! |
Description
This PR adds Waii connector, which allows users to generate SQL queries, get an understanding of their databases, compare/describe queries, and get performance insights for the most expensive queries.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods