Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get charts function #542

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Add get charts function #542

merged 4 commits into from
Dec 9, 2024

Conversation

ravi03071991
Copy link
Contributor

PR to add get_charts function to download the images of charts from the document.

BinaryBrain
BinaryBrain requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@BinaryBrain BinaryBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this function is almost exactly the same as the get_images function, can you reuse the get_images function or refactor to avoid the code duplication?

@ravi03071991
Copy link
Contributor Author

As this function is almost exactly the same as the get_images function, can you reuse the get_images function or refactor to avoid the code duplication?

Sure.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

BinaryBrain
BinaryBrain approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@BinaryBrain BinaryBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@ravi03071991 ravi03071991 merged commit 4740d06 into run-llama:main Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryBrain BinaryBrain BinaryBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravi03071991 @BinaryBrain