Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the input params of "load_data" in NotionPageReader #17529

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

minglu7
Copy link
Contributor

@minglu7 minglu7 commented Jan 16, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
#17522

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 16, 2025
@minglu7
Copy link
Contributor Author

minglu7 commented Jan 16, 2025

@logan-markewich I tried to add a unit test, added parameter descriptions, and corrected the output result type

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@minglu7
Copy link
Contributor Author

minglu7 commented Jan 22, 2025

@logan-markewich Sorry to bother you, I have been waiting for a long time and I hope you can help me review this code

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) January 23, 2025 21:24
@logan-markewich logan-markewich merged commit 2d35a0f into run-llama:main Jan 23, 2025
10 of 11 checks passed
@minglu7 minglu7 deleted the notion branch January 24, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants