Add raids death indicator

[vikke1234]

Similarly to nylo death indicators and tzhaar hp, this plugin is a death indicator for ToA. The idea is to make it able to reliably confirm whether an enemy dies or not. It highlights akkha as a range (e.g. shadow) hit procs shadows.

It accomplishes this by computing the internal fraction for hitpoints.

Currently this only supports Ampken and Akkha. The enemy data for other rooms is a placeholder for v1.x, this is an initial PoC.

[runelite-github-app]

New plugin raids-death-indicator: https://github.com/vikke1234/raids-death-indicator/tree/d566cd962a40504a22ddfe483bf4e618e8d76f32

[vikke1234]

re-running workflows

[iProdigy]

not a full review but: on plugin shutdown you should do overlayManager.remove(overlay); and wsClient.unregisterMessage(EntityDamaged.class);

[vikke1234]

alright, I'll fix it tomorrow 👍

[vikke1234]

re-running workflows

[LlemonDuck]

Pushing a commit will already rerun workflows, you don't need to close/open the PR unless it's very stale

[LlemonDuck]

Downgrade to log.debug https://github.com/vikke1234/raids-death-indicator/blob/42e6b82f1ccdeaf8fce7f5bc4b89b3d0e51ec9a9/src/main/java/com/example/utils/PredictionTree.java#L129

You may also be interested in the scaling work we did in the wiki dps calculator since the raids HP values are rounded in an interesting way: https://github.com/weirdgloop/osrs-dps-calc/blob/main/src/lib/scaling/TombsOfAmascut.ts#L36-L40

[vikke1234]

Hi,

Sorry for the delay, I'm in the middle of a move.

Is the rounding done for all monsters (baba monkeys etc.)? I added that for akkhas shadow, as I found the same thing in the ToA plugin.

[vikke1234]

Pushing a commit will already rerun workflows, you don't need to close/open the PR unless it's very stale

I did this because I had forgot to push to the plugin repo, so the commit didn't exist and I needed to re-run the workflows.

[LlemonDuck]

Path of Apmeken monkeys aren't hp-rounded (they aren't scaled at all anymore). I'm not aware of any other relevant exceptions off the top of my head.