Update no-nullable-attribute-binding fix for null attribute #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes: #317
In versions of Lit >2,
ifDefined
can handlenull
andundefined
so the explicitnull
check is no longer required.Change
Instead of recommending
ifDefined(expr === null ? undefined : expr)
, instead recommendifDefined(expr)
for bothundefined
andnull
.Test
Added message tests to ensure that type detection works correctly, and that the diagnostic message correctly identify either
null
orundefined
. This will make it easier to catch regressions when moving toisTypeAssignableTo
in the future.