Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified: src/automerge.py #5

Merged
merged 11 commits into from
Dec 4, 2024
Merged

modified: src/automerge.py #5

merged 11 commits into from
Dec 4, 2024

Conversation

F-WRunTime
Copy link
Member

@F-WRunTime F-WRunTime commented Nov 27, 2024 •
edited by tothtamas28
Loading

  • Simplified Check: The updated code retrieves the combined status of the latest commit directly.
  • Single Condition: It checks if the combined status state is 'success' to determine if all checks have passed.
  • Logging: It logs a single message if the checks are not passing, indicating the overall state.

Benefits of the Change:

  • Efficiency: The new approach reduces the complexity by avoiding the need to manually iterate over each required check.
  • Readability: The code is more concise and easier to understand, focusing on the overall status rather than individual checks.
  • Performance: By using the combined status, it potentially reduces the number of API calls and processing required.
  • This change streamlines the process of determining if a PR is ready to be merged based on its status checks, making the code more maintainable and efficient.

Minimum requirements
image
image
image
image

@F-WRunTime
modified: src/automerge.py
844be84 
- Modify api end points used to check status. Previous did not have a
  permission option with fine-grained tokens.
- This reduces permissioni requirements to use automerger
@F-WRunTime F-WRunTime self-assigned this Nov 27, 2024
@F-WRunTime
modified: .github/workflows/test.yaml
3f63d9d 
- Update tests to use the new less permissive token.
@F-WRunTime
modified: src/automerge.py
801d63e 
- Checking the 'chech' statuses per commit
- Ccombined commit was not
  always accurate to the mergeable state of  a PR due to annotations and
other items checked not important to basic check passed? Approved? Up to
datae? Yes? Merge.
tothtamas28
tothtamas28 reviewed Dec 3, 2024
View reviewed changes
src/automerge.py Outdated Show resolved Hide resolved
@F-WRunTime
modified: src/automerge.py
447f127 
- Rework logic.
- New dependency for infrastructure to run. Install Github App
  AutomergePR Permission Control to have access to check statuses. Bug
in Github fine-grained tokens or deprecated documentaiton never removed.
@F-WRunTime
modified: .github/workflows/test.yaml
58979d7 
- Updating workflow test to use the GH APP credentials
modified:   README.md
- Modifying instructions and informating need for github and what
  permissions are needed for the github App
@F-WRunTime
Rearrange Github app token step and use app token for check steps
e7ed705
@F-WRunTime
Missed first job adding 'token'
2764b42
@F-WRunTime
References to token were mixed up between jobs and steps outside orig…
eddef9d 
…inating job
@F-WRunTime
Generate token for all repositories under current owner running the a…
03faaef 
…ction
@F-WRunTime
Generate a new token for each job
53976a8
tothtamas28
tothtamas28 approved these changes Dec 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@F-WRunTime @tothtamas28
Update README.md
7fb171e 
Grammar fix in readme.

Co-authored-by: Tamás Tóth <[email protected]>
@F-WRunTime F-WRunTime merged commit 60aae35 into master Dec 4, 2024
2 checks passed
@F-WRunTime F-WRunTime deleted the feature/check-status-permissions-api branch December 4, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothtamas28 tothtamas28 tothtamas28 approved these changes

@rv-jenkins rv-jenkins Awaiting requested review from rv-jenkins

@ehildenb ehildenb Awaiting requested review from ehildenb

Assignees

@F-WRunTime F-WRunTime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@F-WRunTime @tothtamas28