Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups to specifications to enable modularity, re-provability #2451

Merged
merged 22 commits into from
Jun 6, 2024

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented May 29, 2024

Soft Blocked on: runtimeverification/k#4402 (will pass CI without this, but functionality will remain broken, same as on current master)
Blocked on: runtimeverification/k#4411
Blocked on: #2465

These changes are to work towards modularizing the MCD proof suite. Currently, when run with the RPC server, we're running each proof independently instead of re-using subfunctions (eg. using Vat.adduu for Vat.frob). This moves us in that direction.

  • Currently, if a proof is already saved and passing on disc, we still load a KoreServer, which takes several seconds. Now, we skip loading the KoreServer in this case, just reporting it back as already passing (much faster re-runs).
  • When we are viewing or showing a proof, or pruneing and edge or sectioning an edge, we currently were loading a proof and all it's dependencies. This causes crashes. Now, instead we used Minor cleanups to prover, kast k#4402 to make sure we only load the main proof.
  • The return of KCFGExplore.section_edge is fixed. It used to return the new KCFG, but now it just updates it in place. The type-checker didn't catch this because of how the value was unused.
  • We remove the mention of the <exit-code> cell from the mcd and benchmarks proof-suites, as it's never relevant to proofs and is more configuration than is needed. Also some minor formatting issues.
  • Turns on using the booster by default for kevm prove ... invocations.
  • Does not repeat the --use-booster option for kevm section-edge ..., instead just relies on the existing RPCOptions that have been imported.
  • Removes the manual insertion of a KSequence on the <k> cell for proofs, which is no longer needed.

TODO: update required status checks since --use-booster got switched to --no-use-booster.

@ehildenb ehildenb self-assigned this May 29, 2024
@ehildenb ehildenb marked this pull request as ready for review June 5, 2024 22:12
@rv-jenkins rv-jenkins merged commit 20a2924 into master Jun 6, 2024
11 checks passed
@rv-jenkins rv-jenkins deleted the spec-cleanups branch June 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants