-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups to specifications to enable modularity, re-provability #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to date, and passed already
…ncies, for view/show commands
tothtamas28
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soft Blocked on: runtimeverification/k#4402 (will pass CI without this, but functionality will remain broken, same as on current master)Blocked on: runtimeverification/k#4411Blocked on: #2465These changes are to work towards modularizing the MCD proof suite. Currently, when run with the RPC server, we're running each proof independently instead of re-using subfunctions (eg. using
Vat.adduu
forVat.frob
). This moves us in that direction.KoreServer
, which takes several seconds. Now, we skip loading theKoreServer
in this case, just reporting it back as already passing (much faster re-runs).view
ing orshow
ing a proof, orprune
ing and edge orsection
ing an edge, we currently were loading a proof and all it's dependencies. This causes crashes. Now, instead we used Minor cleanups to prover, kast k#4402 to make sure we only load the main proof.KCFGExplore.section_edge
is fixed. It used to return the newKCFG
, but now it just updates it in place. The type-checker didn't catch this because of how the value was unused.<exit-code>
cell from themcd
andbenchmarks
proof-suites, as it's never relevant to proofs and is more configuration than is needed. Also some minor formatting issues.kevm prove ...
invocations.--use-booster
option forkevm section-edge ...
, instead just relies on the existingRPCOptions
that have been imported.KSequence
on the<k>
cell for proofs, which is no longer needed.TODO: update required status checks since
--use-booster
got switched to--no-use-booster
.