Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing the optimize-kcfg parameter #2666

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

PetarMax
Copy link
Contributor

This PR introduces the optimize-kcfg parameter to the proof options, which uses the recently-introduced infrastructure in pyk that optimizes the KCFG on-the-fly.

@PetarMax PetarMax added the enhancement New feature or request label Dec 17, 2024
@PetarMax PetarMax self-assigned this Dec 17, 2024
Copy link
Contributor

@anvacaru anvacaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment

dest='optimize_kcfg',
default=None,
action='store_true',
help='Optimize the constructed KCFG on-the-fly.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a bit more detailed?

Suggested change
help='Optimize the constructed KCFG on-the-fly.',
help='Optimize the constructed KCFG on-the-fly by minimizing consecutive edges.',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what it is now, but we don't know what else it will be in the future.

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 5e7a593 into master Dec 17, 2024
12 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the petar/optimize-kcfg branch December 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants