This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Prover no longer holds a Proof
#960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nwatson22 is this PR blocked by anything? Are we still planning to getting it merged? |
|
Closing in favor of runtimeverification/k#4250. |
rv-jenkins
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 16, 2024
Porting runtimeverification/pyk#960 to K repo. `APRProver.step_proof` currently assumes the proof being passed in the `APRProofStep` it takes as argument is the same as `self.proof`, i.e. when it calls `self.nonzero_depth`, `self._check_subsume`, and `self._checked_for_bounded` assumes the proof being passed in is always the same for a single `APRProver` instance. This is a problem in itself, but changing this should also move us closer an implementation that can run `step_proof` on different nodes in parallel, by reducing its dependency on external data. A next step could be initializing a new KCFGExplore every `step_proof` instead of using `self.kcfg_explore` to access the `KoreClient`. - Removes `proof` field from `Prover` and `APRProver`. - Makes methods that read/write `self.prover` take a prover argument - Proof initialization is performed separately in `init_proof` at the beginning of `advance_proof` rather than in the `Prover` constructor. - Moves `_checked_for_terminal` and `_checked_for_bounded` into `APRProof`, as they refer to nodes of a specific proof.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.