-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrixライブラリの2.6.0での変更の対応など #2527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
最初に
#1977「2.6.0 対応残り」のmatrixライブラリに対するものです。
下記のページに対応しています。
やったこと
※ 最初の2コミットで、古いバージョンの分岐を削除しています。
2.6.0で追加された以下のメソッドを追加しました。
Matrix#map!
,Matrix#collect!
Matrix#[]=
Vector#map!
,Vector#collect!
Vector#[]=
2.6.0で、下記のメソッドが、引数で要素を限定できるようになっていたので、その旨を追記しました。
Matrix#map
,Matrix#collect
下記のメソッドは2.6.0から再定義しなくなったので、
#@until 2.6.0
を付与。Matrix#clone
,Vector#clone
冒頭の
=== Complex クラスとの併用
を削除require 'complex'
をしなくてもComplex
は使え、1.8以前の古い記述が冒頭に大きく残っているようだったので、削除しました。古い内部向けのメソッドらを削除
Vector
のcompare_by
やMatrix
のcompare_by_row_vectors
を削除しました。Vector
のinit_elements
メソッドの記述を削除しました。rank
メソッドの注意書きについてこの文章は、英語版の方の説明を持ってきています。
https://github.com/ruby/matrix/blob/387e5b426fec31e6092280093681b03a59094641/lib/matrix.rb#L1418-L1420
参考