Add simple panic messages #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Jul 12, 2024
src/lib.rs
Outdated
| @@ -1788,8 +1788,8 @@ impl<'a> Builder<'a> { | |||
| .is_none()); | |||
| } | |||
| for tag_name in &self.clean_content_tags { | |||
| assert!(!self.tags.contains(tag_name)); | |||
| assert!(!self.tag_attributes.contains_key(tag_name)); | |||
| assert!(!self.tags.contains(tag_name), "{tag_name} appears in clean_content_tags and in tags at the same time"); | |||
There was a problem hiding this comment.
Nit:
Suggested change
| assert!(!self.tags.contains(tag_name), "{tag_name} appears in clean_content_tags and in tags at the same time"); | |
| assert!(!self.tags.contains(tag_name), "`{tag_name}` appears in `clean_content_tags` and in `tags` at the same time"); |
lnicola
reviewed
Jul 12, 2024
src/lib.rs
Outdated
| assert!(!self.tags.contains(tag_name)); | ||
| assert!(!self.tag_attributes.contains_key(tag_name)); | ||
| assert!(!self.tags.contains(tag_name), "{tag_name} appears in clean_content_tags and in tags at the same time"); | ||
| assert!(!self.tag_attributes.contains_key(tag_name), "{tag_name} appears in clean_content_tags and in tag_attributes at the same time"); |
There was a problem hiding this comment.
Suggested change
| assert!(!self.tag_attributes.contains_key(tag_name), "{tag_name} appears in clean_content_tags and in tag_attributes at the same time"); | |
| assert!(!self.tag_attributes.contains_key(tag_name), "`{tag_name}` appears in `clean_content_tags` and in `tag_attributes` at the same time"); |
lnicola
approved these changes
Jul 12, 2024
notriddle
force-pushed
the
notriddle/panic-msg
branch
from
757cbf1 to
3ffabf6
Compare
Fixes #200 Co-authored-by: Laurențiu Nicola <[email protected]>
notriddle
force-pushed
the
notriddle/panic-msg
branch
from
3ffabf6 to
0fda008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200