Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to retrieve all tags of a BAM record #170

Closed
wants to merge 1 commit into from
Closed

Add method to retrieve all tags of a BAM record #170

wants to merge 1 commit into from

Conversation

jch-13
Copy link
Contributor

@jch-13 jch-13 commented Dec 2, 2019 •
edited
Loading

This PR allows getting all tags from a bam::Record as a Vec of tuples. I am not sure this implementation is the right way to do it, so please be sceptical :)

@coveralls
Copy link

coveralls commented Dec 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 391908695

  • 0 of 26 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 93.653%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bam/record.rs 0 26 0.0%
Totals Coverage Status
Change from base Build 379040825: -0.2%
Covered Lines: 10831
Relevant Lines: 11565
💛 - Coveralls

@jch-13 jch-13 force-pushed the feature/get_all_bam_tags branch from c8cb75e to 400a91f Compare March 17, 2020 13:34
@jch-13 jch-13 force-pushed the feature/get_all_bam_tags branch 2 times, most recently from 6a23827 to a88764b Compare March 26, 2020 11:12
@jch-13 jch-13 force-pushed the feature/get_all_bam_tags branch from a88764b to 6d3c570 Compare April 9, 2020 09:51
@brainstorm brainstorm requested a review from pmarks June 5, 2020 05:32
pmarks
pmarks reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@pmarks pmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jch-13 Thanks, this will be useful! Given that this is unsafe code, I think we should have unit tests that cover the major cases of the match in order to merge this.

@jch-13
Copy link
Contributor Author

jch-13 commented Jun 8, 2020

Sure, good idea! While writing tests covering e.g. Aux::Integer(i64::MAX) I discovered #209, which is probably best resolved before proceeding here...

@dlaehnemann dlaehnemann mentioned this pull request Jun 9, 2020
Closed
@jch-13 jch-13 force-pushed the feature/get_all_bam_tags branch from 2a5d5d5 to fd99c8f Compare October 2, 2020 08:28
@jch-13 jch-13 force-pushed the feature/get_all_bam_tags branch from fd99c8f to 0cebb25 Compare November 30, 2020 15:37
@jlboat jlboat mentioned this pull request Dec 15, 2020
Closed
@jch-13 jch-13 mentioned this pull request Jan 18, 2021
Merged
@jch-13
Copy link
Contributor Author

jch-13 commented Jan 18, 2021

Closed in favor of #292

@jch-13 jch-13 closed this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarks pmarks pmarks left review comments

Assignees

@jch-13 jch-13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jch-13 @coveralls @pmarks