Remove feature gating from test_p2p unit test
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like we need to update our Cargo.toml to fix the "unknown cfg parameter" lint, which is now many months old. I don't think I'll be able to run my local CI on these things without it (and a new clippy run). Can we do that first? |
|
Yes definitely. I saw this was red yesterday but was lazy, sorry for taking your time while you looked. |
tcharding
force-pushed
the
01-21-test-p2p
branch
from
068d034 to
52050fa
Compare
|
Strange that a v17 unit test failed. I re-ran the test. |
This test works for `28_0`. It does not need feature gating out. The reason this was done is because it cannot be run in parallel with `test_multi_p2p`. We can leave that one feature guarded out in v28 builds. The underlying issue is a problem with how Bitcoin Core binds to ports and is tracked in rust-bitcoin#41
tcharding
force-pushed
the
01-21-test-p2p
branch
from
52050fa to
0c08ad7
Compare
|
I'm going to no-ack merge this, it only removes feature gating from test code and is needed by #45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test works for
28_0. It does not need feature gating out.The reason this was done is because it cannot be run in parallel with
test_multi_p2p. We can leave that one feature guarded out in v28 builds.The underlying issue is a problem with how Bitcoin Core binds to ports and is tracked in #41