Release tracking PR: v0.6.0
#49
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `node` crate cannot run multiple instances of Bitcoin Core v28 because of changes to bind logic in that release. The solution is to use `-bind` instead of `-port`. For more information on the relevant changes in Core v28 see: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-28.0.md#p2p-and-network-changes This patch was created with help of @MaxFangX - mad props. Fix: rust-bitcoin#41
Every single use statement in `client_versions` has an `allow` attribute; this is too noisy.
If no features are enabled then a few things happen: - `bitcoind` from `$PATH` is used. - We assume Core version 28 This means that in order to make `--no-default-features` build (which is a reasonable expectation) there are implicit requirements on the environment - this is bad but I see no other solution ATM. Improve the code comments, make the attributes uniform, and add missing version to the no-feature-enabled logic. Document the `bitcoind` version requirements in the README.
The `default` feature is problematic because it overrides `--features=xyz` if `--no-default-features` is used. Remove it.
We moved the `jsonrpc` crate here a while ago but forgot to mention it in the crate list in the repo README - do so.
The problems this crate solves and does not solve is not immediately obvious. Make an effort to explain them.
We have a bunch of stale MSRV docs. Update them all and make the form uniform.
The `types` crate is currently under documented. Improve the documentation in the crate's readme.
In preparation for release bump the version numbers of `types`, `client`, and `node` to `0.6.0`. Add changelog entries to each and update the lock files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because on top of #45, #46, and #48.
This release is mainly because I want to introduce @jamillambert to this repository. Before doing so I want the everything in a state that he has some chance of understanding whats going on.