Bump no-std-net dependency to 0.6, MSRV to 1.53 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI told me that this necessitates an MSRV increase to 1.53, which is now enacted in a second commit. |
chrysn
changed the title
|
Thanks for the quick review, that allows me to rebase #73 and saves me workarounds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no-std-net version currently used (0.5) failed to parse
SocketAddrstrings"[fe80::1]%2", which works correctly in the 0.6 version.Incrementing the version is this easy change (nothing inside current embedded-nal appears to depend on the precise version), but it is an API breaking change in the crates here because types are re-exported and their API changed. (For example,
Ipv6Addr::unspecified()becameIpv6Addr::UNSPECIFIED). Given that these crates have not yet had non-breaking updates, that's probably not a big deal.