Raspi example #133

PatrickLang · 2020-08-04T06:13:31Z

PR description

This merges in a community sample for using the library on a Raspberry Pi, along with a test cross build using GitHub Actions which are free for public open source repos. This was based on a sample shared in #48 which worked well for me.

What do you think about the organization? I can add a few more missing details on how to wire up the lcd and do other cleanup if needed.

Work remaining

CircleCI build step for this sample
Ensure this sample uses the current version of ssd1306 from this repo, not an older released version

Other checks

Check that you've added documentation to any new methods
Rebase from master if you're not already up to date
Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
Check that your branch is up to date with master and that CI is passing once the PR is opened

Not applicable

Add or modify an example if there are changes to the public API

also add build script

* add automated build

jamwaffles · 2020-08-04T07:28:18Z

Thanks for the PR! I think the example might be better placed under examples/raspi as opposed to the current top-level examples-raspi. I'd also prefer not to use two different CI pipelines, so if you're familiar with CircleCI please move the build there. If not, I can take a look at adding the cross based build into CircleCI for you.

PatrickLang · 2020-08-04T19:23:37Z

Sure will update the layout and take a look at circleci. I have used it before

PatrickLang · 2020-08-05T04:33:52Z

I changed the paths, but still need to add CircleCI. I should be able to do that by end of week.

PatrickLang · 2020-08-06T04:10:00Z

@chux0519 - does this look ok to you? I just added more details in the readme. I think my OLED pinout matches yours but I wanted to double check.

I will do the circleCI update soon

slyshykO · 2020-08-06T05:44:28Z

examples/raspi/src/main.rs

+
+    let i2c = I2cdev::new("/dev/i2c-1").unwrap();
+
+    let mut disp: GraphicsMode<_> = Builder::new().connect_i2c(i2c).into();


In new 0.4.0 version Builder have no connect_i2c method.

ah yes that's a good point. examples/raspi/cargo.toml uses 0.3.something. I should update that too.

This should be fixed. I updated a bunch of dependencies and worked around the breaking changes

chux0519 · 2020-08-06T05:56:13Z

@PatrickLang It's been a while since I wrote that, and all code looks good to me.
I think as long as the pipeline passed(not breaking current version), it should be ok

PatrickLang · 2020-08-30T08:28:10Z

Sorry it took me a bit to get back to this. I've been fighting with Jenkins in my day job and haven't been in the mood to work on CI at home ;) I got the sample up to the current library revision and it builds in CircleCI.

Just a note - you may want to move the other build steps to cimg/rust which will supercede circleci/rust

jamwaffles

Hi Patrick, my turn to apologise! I'm sorry I'm an entire year late on getting back to this... lockdowns and mental health struggles have kept me away from doing much OSS work in this time.

Anyway, many thanks for the example and writing up an awesome little tutorial doc with images! I've left a few small comments inline, but the version changes I brought up will need some larger changes to the example code itself.

If you're happy to make the changes, please feel free, otherwise can you switch on the "allow contributors to push to branch" option or whatever its called so I can get this PR merged in? Failing that, I can fork this PR with updates :).

Also please rebase this branch if you have a moment.

I'll do my best to respond in a more timely fashion this cycle!

jamwaffles · 2021-11-12T18:49:46Z

.cargo/config

+[target.armv7-unknown-linux-gnueabihf]
+linker = "arm-linux-gnueabihf-gcc"
+


Is this really required? I don't have this package installed on my M1 mac and the rpi example compiled with no errors.

jamwaffles · 2021-11-12T18:50:02Z

README.md

@@ -93,6 +93,10 @@ fn HardFault(ef: &ExceptionFrame) -> ! {

 ```

+### Raspberry Pi
+
+A sample project is available under [examples/raspi](./examples/raspi)


Nit

Suggested change

A sample project is available under [examples/raspi](./examples/raspi)

A sample project is available under [examples/raspi](./examples/raspi).

jamwaffles · 2021-11-12T18:50:42Z

examples/raspi/Cargo.toml

+embedded-graphics = "0.6.0"
+linux-embedded-hal = "0.3.0"
+machine-ip = "0.2.1"
+ssd1306 = "0.4.0"


I think this should be a path directive to keep the example code here the same as everywhere else:

Suggested change

ssd1306 = "0.4.0"

# NOTE: The `path` directive is used here to keep the example up to date. Use a normal version

# number in real application code.

ssd1306 = { path = "../../" }

jamwaffles · 2021-11-12T18:51:00Z

examples/raspi/Cargo.toml

+# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+
+[dependencies]
+embedded-graphics = "0.6.0"


Suggested change

embedded-graphics = "0.6.0"

embedded-graphics = "0.7.1"

although this breaks some stuff in the example code.

btielen

I would like to suggest to add a file examples/raspi/.cargo/config with

[build]
target = "armv7-unknown-linux-gnueabihf"

to avoid the problem mentioned in #48 (comment)

patricklangsonos · 2022-01-28T00:30:55Z

Thanks! I need to pull my Raspberry Pi back out and make some updates. I put this on hold for a while to work on other projects but may need it again soon.

chux0519 and others added 10 commits November 15, 2019 18:37

init example

a822a98

also add build script

fix: stroke color

7224c33

feat: add image support

3846d90

add loop

100b403

doc: add README

5813ea4

Blank screen on SIGINT/SIGTERM to avoid image retention

807c671

Use cross for easier build

b0b83dc

De-duplicate rust.raw

a261da2

Gh build (rust-embedded-community#1)

0d33a5f

* add automated build

Merging in sample from chux0519/raspi-oled

435029d

Link to and improve README for RaspPi

f538749

PatrickLang force-pushed the raspi-example branch from 7223da3 to a261da2 Compare August 5, 2020 04:32

PatrickLang force-pushed the raspi-example branch from 720c8cd to f538749 Compare August 6, 2020 05:08

slyshykO reviewed Aug 6, 2020

View reviewed changes

PatrickLang added 3 commits August 8, 2020 12:54

Moving to updated dependencies

2cb1fc8

Finish updating dependencies

d2330be

Add CircleCI build for examples/raspi

eea92ff

Remove GitHub CI

053e87d

jamwaffles requested changes Nov 12, 2021

View reviewed changes

jamwaffles mentioned this pull request Nov 12, 2021

Add Raspberry Pi example #160

Closed

6 tasks

btielen reviewed Nov 12, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raspi example #133

Raspi example #133

PatrickLang commented Aug 4, 2020 •

edited

Loading

jamwaffles commented Aug 4, 2020

PatrickLang commented Aug 4, 2020

PatrickLang commented Aug 5, 2020

PatrickLang commented Aug 6, 2020

slyshykO Aug 6, 2020 •

edited

Loading

PatrickLang Aug 6, 2020

PatrickLang Aug 10, 2020

chux0519 commented Aug 6, 2020

PatrickLang commented Aug 30, 2020

jamwaffles left a comment

jamwaffles Nov 12, 2021

jamwaffles Nov 12, 2021

jamwaffles Nov 12, 2021

jamwaffles Nov 12, 2021

btielen left a comment

patricklangsonos commented Jan 28, 2022


		let i2c = I2cdev::new("/dev/i2c-1").unwrap();

		let mut disp: GraphicsMode<_> = Builder::new().connect_i2c(i2c).into();

		[target.armv7-unknown-linux-gnueabihf]
		linker = "arm-linux-gnueabihf-gcc"

	A sample project is available under [examples/raspi](./examples/raspi)
	A sample project is available under [examples/raspi](./examples/raspi).

-ssd1306 = "0.4.0"
+# NOTE: The `path` directive is used here to keep the example up to date. Use a normal version
+# number in real application code.
+ssd1306 = { path = "../../" }

Raspi example #133

Are you sure you want to change the base?

Raspi example #133

Conversation

PatrickLang commented Aug 4, 2020 • edited Loading

PR description

Work remaining

Other checks

jamwaffles commented Aug 4, 2020

PatrickLang commented Aug 4, 2020

PatrickLang commented Aug 5, 2020

PatrickLang commented Aug 6, 2020

slyshykO Aug 6, 2020 • edited Loading

Choose a reason for hiding this comment

PatrickLang Aug 6, 2020

Choose a reason for hiding this comment

PatrickLang Aug 10, 2020

Choose a reason for hiding this comment

chux0519 commented Aug 6, 2020

PatrickLang commented Aug 30, 2020

jamwaffles left a comment

Choose a reason for hiding this comment

jamwaffles Nov 12, 2021

Choose a reason for hiding this comment

jamwaffles Nov 12, 2021

Choose a reason for hiding this comment

jamwaffles Nov 12, 2021

Choose a reason for hiding this comment

jamwaffles Nov 12, 2021

Choose a reason for hiding this comment

btielen left a comment

Choose a reason for hiding this comment

patricklangsonos commented Jan 28, 2022

PatrickLang commented Aug 4, 2020 •

edited

Loading

slyshykO Aug 6, 2020 •

edited

Loading