Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sealed traits for Pin marker traits #50

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Use sealed traits for Pin marker traits #50

merged 3 commits into from
Jul 6, 2022

Conversation

kellda
Copy link
Contributor

@kellda kellda commented Jun 28, 2022

eldruin
eldruin reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
Could you add entries about these changes to the changelogs in each of the READMEs?

@kellda
Copy link
Contributor Author

kellda commented Jul 6, 2022

Done !

eldruin
eldruin approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@eldruin eldruin merged commit 758574c into rust-embedded-community:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellda @eldruin