Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release embedded-hal-* v1.0.0-rc.2, embedded-io-{async,adapters} v0.6.1 #540

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Nov 28, 2023

Requires #537

@Dirbaio Dirbaio requested a review from a team as a code owner November 28, 2023 21:54
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is a lil weird, for some reason github hasn't updated the diff vs master 🤷. With that said, mostly looks good, just one fix for the changelog diff url.

embedded-hal-async/CHANGELOG.md Outdated Show resolved Hide resolved
@Dirbaio
Copy link
Member Author

Dirbaio commented Nov 29, 2023

fixed and rebased, diff shows up ok now

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MabezDev MabezDev enabled auto-merge November 29, 2023 13:49
@MabezDev MabezDev added this pull request to the merge queue Nov 29, 2023
Merged via the queue into rust-embedded:master with commit a8c72e9 Nov 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants