New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named constants to clarify delay-stepdown behavior #542

Merged

Dirbaio merged 2 commits into rust-embedded:master from jamesmunns:james/clarify-delay-consts

Nov 30, 2023

Member

jamesmunns commented Nov 30, 2023

Add some named constants to clarify behavior/intent, which confused at least one person already.

The compiler almost certainly should be able to optimize away N / M * M, but if we'd like to be extra sure, I can add another const.


          Use named constants to clarify delay-stepdown behavior

ca8ef80

jamesmunns requested a review from a team as a code owner

November 30, 2023 13:08


          Fix comments

5656d67

Dirbaio approved these changes

View reviewed changes

Member

Dirbaio left a comment

thank you!

Dirbaio added this pull request to the merge queue

Merged via the queue into rust-embedded:master with commit f7f3c11

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet