Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an explanation of how 7-bit addresses should be aligned within a u8 #544

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Add an explanation of how 7-bit addresses should be aligned within a u8 #544

merged 1 commit into from
Dec 8, 2023

Conversation

jamesmunns
Copy link
Member

No description provided.

@jamesmunns jamesmunns requested a review from a team as a code owner December 8, 2023 09:21
@jamesmunns
Copy link
Member Author

As a note, this seems to match existing drivers and HALs that I spot-checked. We may want to also:

  • add a similar note for 10-bit addresses (I have never used them)
  • potentially go further and say that address values exceeding 0x7F should be treated as an error

eldruin
eldruin approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
Please feel free to send another PR with those enhancements if you want.

@eldruin eldruin added this pull request to the merge queue Dec 8, 2023
Merged via the queue into rust-embedded:master with commit ac10b6a Dec 8, 2023
12 checks passed
@jamesmunns jamesmunns deleted the james/explain-i2c-7bit branch December 8, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmunns @eldruin